Sean Xiaowen Zhang

Results 10 comments of Sean Xiaowen Zhang

> Thank you for taking this on. I couldn't justify any more time on it but I think it's still very relevant to the project. Happy to contribute :)

Addressed most, if not all comments in the previous round of review. Played a bit with two cases regarding how we fetch DagRuns for SLA consideration: 1. Use a fixed...

> Option 1 doesn't guarantee correctness right? i.e. if there are more dagruns that need to be checked than the preset limit, some of them will be ignored? True. I...

Made requested changes, please take a look again :) @houqp @BasPH thanks

CI seems to be having trouble ``` unable to recognize "/opt/airflow/scripts/ci/in_container/kubernetes/app/postgres.yaml": Get https://airflow-python-3.6-v1.15.3-control-plane:6443/api?timeout=32s: dial tcp: lookup airflow-python-3.6-v1.15.3-control-plane on 127.0.0.11:53: no such host ``` I'll re-push but flag it here in...

> hi @seanxwzhang any updates on this patch? Unfortunately, I won't be able to continue working on this patch, happy to hand it over to others.

I'm experiencing the same issue, here's my output from `nvidia-smi` and `pip list | grep nvidia` ``` (base) ➜ ~ nvidia-smi Wed May 8 09:05:06 2024 +---------------------------------------------------------------------------------------+ | NVIDIA-SMI 535.171.04...

I'm encountering the same issue, @banyan-god did you eventually figure out a way to resolve this?

Interesting, in my case it was fixed by not using bf16 but fp16. Surprised that tokenizer can have an effect on what looks like a numerical issue (or perhaps it...