Sebastian Dröge

Results 1153 comments of Sebastian Dröge

There's some initial work on this in https://github.com/sdroege/sdp-types/pull/25 . Can you check if that API would work for you, and if not what you'd prefer?

> That was the point of the [internal build API](https://docs.rs/system-deps/latest/system_deps/#internally-build-system-libraries) but, AFAIK, it has never been really used IIRC `dav1d-sys` is using that

Very interesting, thanks! OOC, what are you planning to implement with this?

Just shortly looked over it, will do a proper review one of these days but generally it looks correct.

Because nobody added it yet. I don't think there's any fundamental problem with it :)

What's the status of this PR?

That sounds great, thanks!

Do you want to provide a PR adding this?

> In that case would it not be better to pass an OwnedFd? The docs for unix_fd_add or unix_fd_add_full don't say much. Good question. But can you get an `OwnedFd`...

Also, shouldn't the `GSource` trigger when it's closed and be destroyed then? From inside GLib I mean.