Sebastian Dröge

Results 1153 comments of Sebastian Dröge

This now has to be updated for the new subclassing API that was merged into `glib` directly a few weeks ago, and for the upcoming changes to the `glib_wrapper!` macro...

That's true, same for `to_glib_none()` etc. Do you want to provide a PR for that?

Fixed via https://github.com/gtk-rs/gtk-rs-core/pull/1666 `to_glib_none()` and others are already not `unsafe`.

Don't think I have anything to add other than that. All those changes are bugfixes and minor additions otherwise, nothing to highlight IMHO :)

Personally I'm not going to touch anything related to the `base64` crate but that's your decision to make :) If the only problem is the MSRV then I would get...

I've added a comment about that to the `data-encoding` PR.

Also, of course, in extension, `tungstenite` works fine with `data-encoding` < 2.5.0 too and the only reason why there are complaints now is because cargo doesn't handle MSRV in any...

`data-encoding` will likely have a lower MSRV with the next release, basically the same as the current release (1.48): https://github.com/ia0/data-encoding/pull/85 That also shows how you can actually test in the...

Related to the cargo issue about not considering MSRV there's a pre-RFC now for implementing that: https://internals.rust-lang.org/t/pre-rfc-msrv-aware-resolver/19871/1

This sounds like a nice idea. We should probably also double-check the status of each of the projects (in case some disappeared).