Stephen Dolenc

comment 1/3 debian "buster" (bash 5) and "stretch" (bash 4.4) tests pass with the following message ``` --- Coverage report Exit codes match Coverage report matches --- _output_contains Output matches...

comment 2/3 debian "jessie" (bash 4.3) and "wheezy" (4.2) outputs ``` --- Coverage report critic.sh: line 179: _args[@]: unbound variable critic.sh: line 280: heredocs[@]: unbound variable critic.sh: line 302: heredocs[@]:...

comment 3/3 debian "squeeze" (bash 4.1) output ``` --- Coverage report critic.sh: line 179: _args[@]: unbound variable critic.sh: line 220: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value]...

sounds good! the awk/gawk fix you suggested did resolve that issue 👍 https://github.com/sdolenc/critic.sh/commit/b39b4f766de69bb205c71be338d2e32887f9ca2a

Hmm. We may be encountering a difference between bash on mac vs. linux. I ran `bash --version` within and outside of the script and they match. Debian 8, 7, and...

I submitted a pr https://github.com/Checksum/critic.sh/pull/8 with fixes and automated testing for bash 4.2 and above. I hope that change looks okay for merging. I haven't enabled tests for bash 4.1...

I'll take a look :) We're using version pinning when installing packages so our tests know which version to expect. I'm guessing a version the dockerfile(s) is using has been...

I submitted a pull request https://github.com/kdabir/has/pull/47 which is a proposed change to branch kdabir:change-docker-test-containers. If it looks good and you merge it then it will auto-update your existing pull request...

Awesome! I'm fairly confident the containers will build properly now, but I just discovered two small test failures that I'll submit a pull request for shortly. Sorry The first fix...

tests are frixed with https://github.com/kdabir/has/pull/48. The six npm package tests will pass on ubuntu after a new ubuntu container is built