test container location

[sdolenc]

Thank you for merging https://github.com/kdabir/has/pull/43 which gets us closer to testing every package has supports. I'll aim to submit pull requests that get us even closer to 100% in the future.

The Github Actions tests are currently using containers built from my fork of has, but it would be better if we built the containers using this official fork https://github.com/kdabir/has . That way future changes to the official dockerfiles would update the containers we use for testing.

If that sounds okay to you then could you please

1. Sign in to https://hub.docker.com/ to create a new testing-has repository
2. Build the four dockerfiles using settings similar to these
3. Then (after successful builds) updating Github Actions to use the official images instead of the "sdolenc" ones https://github.com/kdabir/has/blob/4ccd0177d458800f7cc721df08c2f0ad643990ac/.github/workflows/main.yml#L25 and https://github.com/kdabir/has/blob/4ccd0177d458800f7cc721df08c2f0ad643990ac/.github/workflows/main.yml#L44

If it helps: I've added you as a collaborator for my repository on https://hub.docker.com

[kdabir]

Hi,

First off, thanks for detailed steps so that it was easy to follow for me. Never published any containers on dockerhub.

I tried creating the containers using the checked in script, however it failed. https://hub.docker.com/repository/docker/kdabir/has-test-containers/builds

Do you know what could be the reason?

[sdolenc]

I'll take a look :) We're using version pinning when installing packages so our tests know which version to expect. I'm guessing a version the dockerfile(s) is using has been removed from the alpine/ubuntu package repository. I'll submit a PR to fix the issue soon

[sdolenc]

I submitted a pull request https://github.com/kdabir/has/pull/47 which is a proposed change to branch kdabir:change-docker-test-containers. If it looks good and you merge it then it will auto-update your existing pull request https://github.com/kdabir/has/pull/46

I don't anticipate there will be many future issues, but as I mentioned in the description of https://github.com/kdabir/has/pull/47

i'll look into setting up daily builds of my fork's containers so I can catch any future problems

[kdabir]

Hey, thanks for helping here. I have merged the branches. Docker containers are still being built (dockerhub) once that's complete, I hope all the actions will pass.

[sdolenc]

Awesome! I'm fairly confident the containers will build properly now, but I just discovered two small test failures that I'll submit a pull request for shortly. Sorry

The first fix does not require new container builds. The version of eb that gets installed on ubuntu is 3.18.1, but I set the "expected" version as 3.18.0. Draft fix: https://github.com/kdabir/has/compare/master...sdolenc:testfix-eb-on-ubuntu?expand=1

The second issue is caused by the new way we're installing npm on ubuntu. I need to add globally installed npm packages to the path so has can see brunch, grunt, gulp, heroku, netlify, and serverless. This fix requires a new build of the ubuntu container.

Update: The draft linked above includes fixes for both issues. I'll verify everything builds and tests pass before submitting the pull request.

[sdolenc]

tests are frixed with https://github.com/kdabir/has/pull/48. The six npm package tests will pass on ubuntu after a new ubuntu container is built