anndata icon indicating copy to clipboard operation
anndata copied to clipboard

obsm to_df

Open Hrovatin opened this issue 2 years ago • 7 comments

Enable to_df conversion of obsm

Hrovatin avatar May 28 '22 17:05 Hrovatin

Solves #775

Hrovatin avatar May 28 '22 17:05 Hrovatin

Codecov Report

Merging #776 (dd78a3c) into master (a3af650) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   83.10%   83.14%   +0.03%     
==========================================
  Files          34       34              
  Lines        4416     4420       +4     
==========================================
+ Hits         3670     3675       +5     
+ Misses        746      745       -1     
Impacted Files Coverage Δ
anndata/_core/anndata.py 83.49% <100.00%> (+0.08%) :arrow_up:
anndata/_core/merge.py 93.45% <0.00%> (+0.29%) :arrow_up:

codecov[bot] avatar May 28 '22 17:05 codecov[bot]

@Hrovatin I'll check out the docstring. Could you please add a quick test next to https://github.com/scverse/anndata/blob/f563dadad3fcf08d637a5ce1fb42c84d26481f8f/anndata/tests/test_base.py#L469= for this, please?

I'll then review your code.

Thank you!

Zethson avatar May 28 '22 20:05 Zethson

@Zethson added test

Hrovatin avatar May 29 '22 19:05 Hrovatin

@ivirshup do you approve the feature? I can review the PR then.

Zethson avatar Jun 03 '22 09:06 Zethson

@Hrovatin, @Zethson are you still planning on merging this feature at some point?

WeilerP avatar Mar 06 '24 14:03 WeilerP

@WeilerP, I've commented on the original issue, but I'm generally :-1: on this.

If you have particular use cases or needs that make this more valuable please make your case there:

  • https://github.com/scverse/anndata/issues/775

ivirshup avatar Mar 06 '24 14:03 ivirshup