anndata
anndata copied to clipboard
Start backed sparse support for zarr
Initial draft of backed sparse array support for zarr.
- [ ] I intend to export
sparse_dataset
,CSRDataset
, andCSCDataset
class fromexperimental
. - [ ] Get tests passing
- [ ] Figure out if I'm going to expose any arguments through
read_zarr
Codecov Report
Merging #765 (ad016a6) into main (88dd129) will decrease coverage by
2.09%
. The diff coverage is92.74%
.
Additional details and impacted files
@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 84.88% 82.79% -2.09%
==========================================
Files 36 36
Lines 5153 5197 +44
==========================================
- Hits 4374 4303 -71
- Misses 779 894 +115
Flag | Coverage Δ | |
---|---|---|
gpu-tests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files Changed | Coverage Δ | |
---|---|---|
anndata/_core/anndata.py | 83.60% <66.66%> (ø) |
|
anndata/_core/file_backing.py | 90.32% <87.50%> (-1.15%) |
:arrow_down: |
anndata/_io/specs/methods.py | 87.52% <90.00%> (-0.19%) |
:arrow_down: |
anndata/_core/sparse_dataset.py | 92.73% <93.15%> (+1.06%) |
:arrow_up: |
anndata/_core/raw.py | 79.28% <100.00%> (-4.29%) |
:arrow_down: |
anndata/_io/h5ad.py | 92.89% <100.00%> (ø) |
|
anndata/_io/utils.py | 76.47% <100.00%> (ø) |
|
anndata/experimental/__init__.py | 100.00% <100.00%> (ø) |
|
anndata/experimental/merge.py | 87.56% <100.00%> (ø) |
|
anndata/experimental/multi_files/_anncollection.py | 70.56% <100.00%> (ø) |
|
... and 2 more |
@ivirshup It seems that we settled on friday on not exposing anything for read_zarr
. beyond that, i was not clear what the goal of assignment would be here - did you want to include it or not? i remember you saying that writing in backed mode probably wasn't so great anyway so is the goal here to get rid of it?
Initial draft of backed sparse array support for zarr.
- [ ] I intend to export
sparse_dataset
,CSRDataset
, andCSCDataset
class fromexperimental
.- [x] Get tests passing
- [ ] Figure out if I'm going to expose any arguments through
read_zarr
At the moment, the first and last are still open ended as is the question of setting the data. Otherwise, tests pass and you can convert from a draft IMO. Thanks again for getting this started!
Decisions:
- don't expose arguments to
read_zarr
- do export the classes from
experimental
. -
DeprecationWarning
for sparse setting - eventually remove probably, but leave space for a new implementation.
@ivirshup Where is the changelog? Is it the release-notes
? And if so, which release?
Where is the changelog?
release-notes/0.10.0.md
@ivirshup have look at the deprecation warning! thanks!
I'm not sure where I got the idea in my head that this branch was passing CI but in any case, should we make zarr
a dep of anndata
now? It's only used for type checking right now in sparse_dataset.py
This is what is causing the failures.
In anndata.compat
there are dummy classes defined for this. Basically replace zarr.Array
and zarr.Group
with anndata.compat.ZarrArray
and anndata.compat.ZarrGroup