anndata icon indicating copy to clipboard operation
anndata copied to clipboard

Redo branch protections to allow creating new release branches

Open ivirshup opened this issue 10 months ago • 4 comments

Creation of new backport branches is blocked by the current rule sets.

I believe @flying-sheep switched the repo from branch protections to rule sets, because branch deletion rules got applied to meeseeks backport branches.

I think we had avoided this problem previously by not protecting branches from deletion.

I've temporarily worked around this by just turning off the repo rules before pushing up the 0.10.x branch.

ivirshup avatar Oct 06 '23 12:10 ivirshup

Some examples of what this looks like:

$ git push -f --set-upstream origin 0.10.x
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: GH013: Repository rule violations found for refs/heads/0.10.x.
remote: Review all repository rules at http://github.com/scverse/anndata/rules?ref=refs%2Fheads%2F0.10.x
remote: 
remote: - Required status check "scverse.anndata" is queued.
remote: 
To https://github.com/scverse/anndata.git
 ! [remote rejected] 0.10.x -> 0.10.x (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/scverse/anndata.git'
image

ivirshup avatar Oct 06 '23 12:10 ivirshup

I'm not seeing a readthedocs check for main, but we are definitely doing builds on main... Maybe that's related?

ivirshup avatar Oct 06 '23 12:10 ivirshup

Hm, readthedocs probably doesn’t run as a GitHub check on main. Their PR builds were introduced later, so the “regular” builds probably don’t get reported back to GitHub.

I assume that it’s somehow this ruleset being responsible: https://github.com/scverse/anndata/settings/rules/87619. “Require status checks to pass before merging” does have the listed checks 1. pipelines (which reports check results on main) and 2. rtd (which doesn’t).

Seems like for rulesets, “Require status checks to pass before merging” actually means “Require status checks to pass before merging or pushing a new branch”

flying-sheep avatar Oct 06 '23 13:10 flying-sheep

This issue has been automatically marked as stale because it has not had recent activity. Please add a comment if you want to keep the issue open. Thank you for your contributions!

github-actions[bot] avatar Dec 06 '23 02:12 github-actions[bot]