Scott Trinh

Results 319 comments of Scott Trinh

Oh, excellent news! Looks like the webhook just went out about 58 minutes _after_ the tag was created. 😬 > I'll see if I can't simplify the build process using...

@blecorre-mnp No new updates to share here, but I'll spend a little time ASAP to try to get a reproduction together. If you have time to attempt getting a _minimal_...

> My guess is that from what I read in the source code, using SCRAM authentication, the client is supposed to HMAC multiple times (4096 ?) the password and it...

Oh, one thing that just occured to me is that Node 18 includes support for `globalThis.crypto` (behind a flag) which we will use if available. Perhaps the change from 16...

Oof, yeah, it seems like `crypto.subtle.sign` is _way_ slower the the equivalent code in `node:crypto`: ``` ┌─────────┬─────────────────────────────────────────┬───────────┬────────────────────┬──────────┬─────────┐ │ (index) │ Task Name │ ops/sec │ Average Time (ns) │ Margin...

@blecorre-mnp The change in #1063 should make a pretty noticeable difference, but I think that I _do_ want to swap the logic here, so I'll probably wait for that before...

@blecorre-mnp @ElijahJohnson5 Just pushed #1063 and #1064 which _should_ switch to the faster `node:crypto` implementation. Latest canary contains both of these changes: - [`edgedb`](https://www.npmjs.com/package/edgedb/v/1.6.0-canary.20240724T160428) - [`@edgedb/generate`](https://www.npmjs.com/package/@edgedb/generate/v/0.6.0-canary.20240724T160450) You'll probably need to...

@blecorre-mnp Thanks for your patience here. I should've remembered about 18 introducing the `globalThis.crypto`, but I am still very shocked at the 10x performance difference for HMAC here. 🤯

[v1.5.8](https://github.com/edgedb/edgedb-js/releases/tag/v1.5.8) is out now which includes this change! Thanks everyone for their patience and help getting to the bottom of this head-scratcher!

@lostfutures Indeed! https://github.com/edgedb/edgedb-js/pull/1039 should fix this and is available by updating your `@edgedb/generate` and `edgedb` packages to the `canary` tag which includes those fixes. Will work on getting a `latest`...