Scott Trinh

Results 319 comments of Scott Trinh

@CarsonF > what do you think about an intermediate object to decouple input/output? I'm not sure I understand the suggestion here 🤔

Ahh, I understand now. Seems reasonable so we'll have to answer the question of which is better on some other axes: 1. What is more intuitive for the end user?...

> As far as # 1 goes, fetch has the same API Yeah, and while I agree that works as a primitive since it allows you to have one function...

OK, so @diksipav and I have been going back and forth a bunch about the API here, and I think I have some more concrete thoughts on `await queryRag(message, context).text()`...

Yeah, this is interesting because `null` is a valid JSON value, but `null` has a special meaning w.r.t. parameters. I'll have a think about this and see how we want...

> Ah, I see what you mean. So null is not not assignable to required JSON. Yeah, but I'm not sure about the semantics here. I'll want to align this...

> when you do that it writes it as empty set and not as null Yeah, I believe this is a fundamental issue exactly like that. Making json inputs strictly...

@spalger Sorry for the fiddly-ness here! I agree we should have some way to silence this interaction. I'll add it to the TODO list.

> How should/can this be limited to only 4.8/5.0+ instances? IMO, on earlier versions we continue to silently fail, which is exactly as bad as the current state.