scottmcm
scottmcm
My instinct here (with my lang hat on but not speaking for the team) is that saying this for *every* fat pointer is premature, because we don't know what all...
I think it would be helpful for the RFC to include an example of implementing this for a type which is indexed by user-defined types, not just comparatively-simple case of...
I think it should still be an RFC, because even if it's not a trait, it's very clearly setting a precedent. (As in, it'll be an API that people will...
@Nokel81 I think that's mostly up to you. If you think that the discussion in this thread is valuable for people reading an updated RFC, then updating this one is...
👍 for niko's description in https://github.com/rust-lang/rust/pull/129582#issuecomment-2315724462 @rfcbot reviewed
I find the argument that it should always be ok to make a non-atomic read into an atomic read persuasive, so it sounds good from an intent perspective. So as...
The "actual code" here hasn't changed since the review above (albeit many dozen tests were fixed), so @bors r=compiler-errors rollup=iffy (there's probably some platform-specific simd I missed somewhere)
@bors r=compiler-errors
@bors r=compiler-errors
Could we maybe change this from being a `NullOp` to being something more like a ? I've always thought it really weird that it's a nullop in the first place,...