scottmcm

Results 253 comments of scottmcm

Thanks! This looks good. @bors r+

I think I can take the review here. The APIs are unstable, so don't strictly need libs-api. r? @scottmcm Because this adds an intrinsic, can you also add a codegen...

Thanks! I think this is good to go now. If there's other tweaks that come up they can be future PRs. @bors r+ rollup=iffy (codegen stuff probably shouldn't be in...

Since this PR does do llvm-stuff with pointer types, this failure looks like it might be legit (https://github.com/rust-lang-ci/rust/runs/7843167630?check_suite_focus=true#step:25:7649), so please take another look here, @WaffleLapkin. @bors r- @rustbot author

> Maybe codegen would be a better fit? That would mean it would have the monomorphized versions of the enum too, right? Could be handy for anything using a generic...

That looks like a legitimate failure to me, @rustbot author @bors r-

The bors queue is suspiciously empty, so I suspect there's an infra problem here, not something wrong in the PR.