scottmcm

Results 201 comments of scottmcm

Does this *need* to go in insta-stable? My default lang-hat answer for these things is that it should go in feature-gated first, so it just needs a compiler r+ right...

@bors try @rust-timer queue

Wow, this totally changes the pattern of LTO in clap: ![image](https://user-images.githubusercontent.com/18526288/183218652-5b391b00-b4a6-42ec-ab68-1041d74c8bc2.png)

I'm going to send this over to r? @m-ou-se because I think this is going to be as much a policy decision (about compile-vs-runtime) as it is about the code...

@rfcbot concern not-while-rustfmt-breaks-on-it I remembered it not formatting last I tried using it in rustc, and sure enough it still seems to fail when I try it in playground: (There's...

> it's not modifying what was already there I think that's my complaint. I think it's clear that we'd *want* rustfmt to format it, but based on https://rust-lang.github.io/rfcs/2437-rustfmt-stability.html it'd need...

Thanks for the extra context, @calebcartwright ! I was unaware of that, so will @rfcbot resolve not-while-rustfmt-breaks-on-it (We had a helpful conversation in the lang team meeting about it too...

Multiple lints could be nice for having a couple of different thresholds, with correspondingly-different default lint levels. As a strawman, thinking only about x64, - `huge_assignments`, deny-by-default, for (64 KiB,...

I don't know enough about tasks/futures to be a good reviewer here. r? libs