Scott Marlow

Results 240 comments of Scott Marlow

Does the signature test pass or fail due to this issue? I expect that you would see a failure but would be good to include the test failure.

> Thanks @ChristinaDsl. > > I've made some specific notes, but overall @scottmarlow will need to approve this. > > Scott, AIUI once my comment re WEB_PERSISTENCE_XML is addressed, the...

Hi @marko-bekhta, sorry that I missed your ping on this issue earlier this week. :( I started building https://github.com/marko-bekhta/hibernate-search/tree/fix/batch locally and will try to look at building the https://github.com/marko-bekhta/wildfly/tree/feat/hibernate-search-jakarta-batch change...

`mvn clean install -Dtest=org.wildfly.test.preview.hibernate.search.batch.HibernateSearchBatchTestCase` passed for me locally which is a good sign.

> hey 😃 no worries 😃 Thanks for taking a look at it! > > > `mvn clean install -Dtest=org.wildfly.test.preview.hibernate.search.batch.HibernateSearchBatchTestCase` passed for me locally which is a good sign. >...

I tried running the test again but this time from the correct folder. The test fails right away. Steps that I followed: 1. build wildfly 2. cd testsuite/preview/basic 3. mvn...

Perhaps something like `jakarta.persistence.entitymanagerfactory.make_beanname_unique` to imply that the bean name should be generated to be unique but that doesn't work as how would the application developer know what the bean...

I'm not sure of the solution but think I will rename this issue to just reflect the problem that needs to be solved.

Some possible solutions: 1. Do not name the EntityManagerFactory bean for persistence unit definitions that have the same persistence unit name as other persistence unit definitions in the same application...

> @scottmarlow does https://github.com/jakartaee/platform-tck/pull/2442 remove all excluded tests from the platform TCK or just a subset of them? The pull request enabled tests that were previously disabled and also removed...