Scott Marlow
Scott Marlow
https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/lastCompletedBuild/ passed with https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-servlet-tck-6.0.1.zip for this challenge (using https://download.eclipse.org/ee4j/glassfish/glassfish-7.0.0-M9.zip). https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-jakartaeetck-run-100/153 passed using https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-jakartaeetck-10.0.1.zip + https://download.eclipse.org/ee4j/glassfish/glassfish-7.0.0-M9.zip.
I think that this issue can be closed since https://github.com/jakartaee/specifications/pull/579 is merged and the challenged TCK tests excluded from https://download.eclipse.org/jakartaee/servlet/6.0/jakarta-servlet-tck-6.0.1.zip + https://download.eclipse.org/jakartaee/platform/10/jakarta-jakartaeetck-10.0.1.zip
> Before we close this, do we have a replacement issue to re-enable this test with less strict assertions? +1 for adding a tracking issue or pull request for updating...
https://ci.wildfly-swarm.io/job/thorntail-examples-pull-request-linux might need some changes, will see what happens with this pr testing first! For local testing, I used Docker to start MongoDB.
Thanks for the review, I hope to spend more time on this soon, I also want to see if I can improve the password handling a bit also, to use...
> Thanks for putting this together. I would be very interested in getting something into the signature test plugin to only check the Jakarta namespace. I think that would reduce...
> @scottmarlow since this library is so integral to Jakarta EE TCK testing should eclipse manage a fork of this project so we can make these kind of changes? The...
@KyleAure I just noticed that https://github.com/jtulach/netbeans-apitest/blob/master/src/main/java/com/sun/tdk/signaturetest/core/PackageGroup.java#L99 already contains a package check which is called from https://github.com/jtulach/netbeans-apitest/blob/master/src/main/java/com/sun/tdk/signaturetest/SignatureTest.java#L1575 (also see comment https://github.com/jtulach/netbeans-apitest/blob/master/src/main/java/com/sun/tdk/signaturetest/SignatureTest.java#L247 which mentions that package names can be identified).
Tracking issue for future proofing against further JDK changes is https://github.com/jakartaee/platform-tck/issues/1207 and as mentioned there, I wasn't able to replace the JDK class exclude list with just the package names...
> @scottmarlow since this library is so integral to Jakarta EE TCK testing should eclipse manage a fork of this project so we can make these kind of changes? The...