Scott Clampet
Scott Clampet
Hey @alanzeino! Just FYI. The iOS team is actually working on migrating all Carthage dependencies over to Swift Package Manager. We're almost done in fact and will likely be removing...
> (Oddly though, it was never included in any of the targets when it was a binary but was still referenced somewhere) @msadoon Yea I noticed the same thing with...
@amy-at-kickstarter I added tests for `StripeIntentService` and also made it a class instead of a struct. My goal is to ensure that intent requests are made with the correct data...
@amy-at-kickstarter, I did the following from our Slack discussion: - Removed the service from `Environment` and injected it only into the ViewModels needing it. - Updated `MockStripeIntentService` so that it...
@ifosli addressed your comments. There are a bunch of new file changes now after [renaming that struct](https://github.com/kickstarter/ios-oss/pull/2174/commits/e98ee993d152c9dc67be1cd6dfdfaf5aadd3ef12). Should be easy enough to see each of your comments being addressed by...
@ifosli I've reached out about whether displaying values in a min-max format is appropriate for all languages. We believe that it's fine, or else the translation team likely would have...