ios-oss icon indicating copy to clipboard operation
ios-oss copied to clipboard

[MBL-1667] String Translations

Open scottkicks opened this issue 1 year ago • 2 comments

📲 What

Pulls in the latest strings translations and replaces our hard coded strings accordingly.

  • Also sneaks in a quick change so that the configureEstimatedShippingView returns optional Strings and some extra cleanup
  • If you feel that these changes should be kept separate in their own PR lmk.

🤔 Why

KS supports multiple countries.

🛠 How

run make strings update hardcoded strings

scottkicks avatar Aug 26 '24 20:08 scottkicks

@ifosli I've reached out about whether displaying values in a min-max format is appropriate for all languages. We believe that it's fine, or else the translation team likely would have called that out when translating.

I'll handle any updates if they come back saying we need them.

scottkicks avatar Aug 26 '24 20:08 scottkicks

1 Warning
:warning: Big PR

Generated by :no_entry_sign: Danger

nativeksr avatar Aug 27 '24 16:08 nativeksr