Stefano Cordio
Stefano Cordio
Thanks, @wilkinsona! I'll address them later in the day.
If I understand it correctly, you're looking for a factory method like `given(Supplier)`, to be chained with `when(Function)` that takes the result of the supplier and offers assertion capabilities afterward,...
The direction looks good to me, @arukiidou 👍
@erizzo do you also experience the following? ``` [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/runner/work/assertj/assertj/assertj-core/src/main/java/module-info.java:[55,19] net.bytebuddy cannot be resolved to a module [INFO] 1 error [INFO] -------------------------------------------------------------...
> Do you mean with this branch or on `main`? There shouldn't be changes from this branch that would cause it, it should be practically equivalent to `main`. In the...
> ``` > [INFO] ------------------------------------------------------------- > [ERROR] COMPILATION ERROR : > [INFO] ------------------------------------------------------------- > [ERROR] /home/runner/work/assertj/assertj/assertj-core/src/main/java/module-info.java:[55,19] net.bytebuddy cannot be resolved to a module > [INFO] 1 error > [INFO] -------------------------------------------------------------...
So far, I can't find anything unusual in our build that would cause such an error. I'll cherry-pick the other fixes, but the current error with ByteBuddy prevents us from...
I was also thinking whether the two `convert` methods could be merged into a single: ```java Object convert(@Nullable Object source, AnnotatedElementContext context) ``` but that would be a more aggressive...
Thanks for the feedback, @jazerix! I'll move this issue to the main repo as we might want to consider behavior changes in version 4.
@erizzo I cherry-picked your changes to fix the Eclipse errors, I hope that helps on your local environment! (still, I don't know why the [CI job](https://github.com/assertj/assertj/pull/4002) fails with the module...