Stefano Cordio
Stefano Cordio
Thanks for the feedback, @marchof! These are definitely improvements we can apply.
Sure, @nstdio. If you have already an idea on how to support this use case, feel free to create a PR! I think it would be helpful if we could...
There is nothing wrong with your changes, it's rather a general problem we have with pitest. Feel free to ignore that failure.
I think it would be possible to add an overloaded version of `assertThatCode()` accepting `Callable` and exposing a `result()` method, so we would be able to write something like: ```java...
`catchThrowableOfType` is in line with `catchThrowable` and returning `null` is currently the expected behavior for both, as mentioned in the Javadoc. I understand your point, however, I am not sure...
Thanks for the PR, @spring1627. We still have some points to clarify as mentioned in https://github.com/assertj/assertj-core/issues/2329#issuecomment-919539181 and the direction we want to take with these assertions is not clear yet....
The Javadoc creation [runs with Java 11](https://github.com/assertj/assertj-core/blob/main/.github/workflows/release.yml#L18) but [targets Java 8](https://github.com/assertj/assertj-core/blob/main/pom.xml#L431). A way to fix it could be aligning the `maven-javadoc-plugin` to the `maven-compiler-plugin` configuration.
I'm not sure about the compatibility with Java 8 projects, but we should be able to have integration tests and verify that everything works correctly.
We may also need to remove the [`--no-modules-directories`](https://github.com/assertj/assertj-core/blob/6a4e54cbad5198246ae41a21d8432c503b5c70ce/pom.xml#L32) javadoc option, which would allow the removal of the [Java 13](https://github.com/assertj/assertj-core/blob/6a4e54cbad5198246ae41a21d8432c503b5c70ce/pom.xml#L557-L565) Maven profile.
@ascopes I'm struggling to put together a reproducible example and a suitable test accordingly. Would you mind sharing a small Maven project to reproduce this issue? I'm afraid the fix...