Stefano Cordio

Results 593 comments of Stefano Cordio

My suggestion is not to close the door for `Type getType()` so maybe `Class getRawClass()` or similar? Mostly to be ready for cases where `TypeDescriptor` might wrap a `ParameterizedType`.

> To start with, I had thought a relatively simple interface should suffice for `TypeDescriptor`. > > ```java > interface TypeDescriptor { > Class getType(); > } > ``` So...

After renaming to `Converter`, I realized `StringToObjectConverter` is pretty much a similar abstraction. I propose to refactor the `StringToObjectConverter` hierarchy and rewrite all classes as `Converter` implementations (still with package-private...

@marcphilipp @sbrannen I'm just leaving this here 🙃 https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-pull-request-reviews-in-your-repository

Now that `Converter` has type parameters, would it make sense to implement that in `TypedArgumentConverter` so that the existing `TypedArgumentConverter` implementations could also be used with the new SPI? Before...

@marcphilipp @sbrannen I think this is now ready for another round of reviews! A few points that still require work: * Better test coverage (unit and integration tests) * Documentation...

The JUnit Framework also creates a [BOM via Gradle](https://github.com/junit-team/junit-framework/blob/main/junit-bom/junit-bom.gradle.kts).

The CI [fails with compilation errors](https://github.com/scordio/spring-batch-extensions/actions/runs/11343362613), I'll look into them.

> The CI [fails with compilation errors](https://github.com/scordio/spring-batch-extensions/actions/runs/11343362613), I'll look into them. [It looks good now](https://github.com/scordio/spring-batch-extensions/actions/runs/11346541116) – something was wrong with `spring-cloud-contract-wiremock`. Anyway, I had in mind to replace it with...

> Please add your name as author in all files (ie add `@author` tag in the javadoc of all classes, tests included) as well as in the `Staying in touch`...