Stefano Cordio
Stefano Cordio
@tobi5775 would you be able to provide the ScanCode execution details for AssertJ and the expected output so we can make sure we're covering your use case?
Thanks a lot, @tobi5775. Any specific command line parameter we should consider to execute the scanning?
#3017 might have an impact on this topic.
Related: [LEGAL-642](https://issues.apache.org/jira/browse/LEGAL-642)
Yes, I'd copy the existing documentation.
> Should I also mention the new method in the old methods description? Yes, you could add a `@deprecated` entry in the Javadoc similarly to what we have with [`AbstractThrowableAssert::getCause`](https://github.com/assertj/assertj/blob/main/assertj-core/src/main/java/org/assertj/core/api/AbstractThrowableAssert.java#L184).
> > Now for unit tests should I also use similar unit tests as the old methods do? Or should I change the method calls in the tests to the...
It's caused by the `standard_assertions_and_bdd_assertions_should_have_the_same_non_assertions_methods` test method in `Assertions_sync_with_BDDAssertions_WithAssertions_and_soft_assertions_variants_Test`. To fix it, you need to add new entry point methods in `BDDAssertions`, in line with the changes you did in...
I agree with @vlsi, also mentioned in https://github.com/assertj/assertj/issues/2821#issuecomment-1291911809: > We believe that the readability of Java code can also benefit from this change. PR renamed.
We should also add a Kotlin-based test as the whole topic started from there. I'll take care of it.