Stefano Cordio

Results 595 comments of Stefano Cordio

Thanks for the offer, @pbacz! Paging @joel-costigliola here

Thanks for your first contribution, @ryber! We'll go ahead with the merge after releasing 3.25.2 (expected later this month).

Thanks for your first contribution, @ryber!

I'd suggest either rebase or merge but it's totally up to you. We'll anyway squash the changes in a single commit once ready.

[`extracting(Function, InstanceOfAssertFactory)`](https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org/assertj/core/api/AbstractObjectAssert.html#extracting(java.util.function.Function,org.assertj.core.api.InstanceOfAssertFactory)) internally relies on [`asInstanceOf`](https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org/assertj/core/api/Assert.html#asInstanceOf(org.assertj.core.api.InstanceOfAssertFactory)) which performs a preliminary [`isInstanceOf`](https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org/assertj/core/api/Assert.html#isInstanceOf(java.lang.Class)) check, the source of the `AssertionError` you are experiencing. Is there a reason why you are using `InstanceOfAssertFactories.STRING` even...

It's a fair request 🙂 However, we need a more comprehensive analysis of what this change would mean, especially because [we expose some more generic versions of `extracting`](https://github.com/assertj/assertj/blob/a315d038ab746652bdbcbd47b451d881efceccef/assertj-core/src/main/java/org/assertj/core/api/AbstractAssert.java#L1106-L1164) for third-party...

You're referring to `hasNoPermittedSubclasses()`, right? (I just edited the description to show the expected parameters for the two methods) > From a Java perspective, it is impossible to create a...

@pbacz I propose we add only `hasPermittedSubclasses` with `contains` behavior and we can always add more if there is a concrete demand. WDYT?