Ville Skyttä

Results 283 comments of Ville Skyttä

Verified that it's the `~/.envrc` and `use asdf` indeed that sets `GOROOT` and `GOPATH`. They are not set by anything else on my shell startup.

Guess there are kind of two problems here: 1) What sets GOROOT and GOPATH? They are set at the point you refer to, so exec-env won't touch them, but nothing...

#151 fixes the incomplete `$PATH` setup. Problem with `$GOPATH` and `$GOROOT` remains, will try to find time for that soonish.

>>use asdf indeed that sets GOROOT and GOPATH > Yes, looks like asdf-golang exec-env does that, but [ONLY if not already defined](https://github.com/kennyp/asdf-golang/blob/master/bin/exec-env#L4). Hmm, this could arguably be a bug and...

I've filed https://github.com/kennyp/asdf-golang/pull/80 which fixes the remaining issues for me. In the meantime, I'm doing ```shell use asdf unset -v GOROOT GOPATH ``` ...in all my `.envrc`s, which implements my...

I can see a few differences between @pikeas' report and @vic's reproducer try: - the former mentions the problem being fallback to the system version, latter does not mention system...

Haven't used lefthook myself yet, but eyeballing it. To me the approach taken by pre-commit has worked so well that I have never even thought about it. In a nutshell,...

> It would be very nice if golangci-lint respected the linter directives of supported linters. A bit tangential here, but I opened #2671 about that. For some linters such as...

@SVilgelm @alexandear sorry about the ping, just making sure you've noticed @moitias' comment above -- if you could let us know what you think so we can get this moving...

As noted, the make completion is already too complex for my taste and this makes it even more complex. Then again, we have the test cases here which appear to...