Ville Skyttä

Results 433 comments of Ville Skyttä

I wonder if we have some unfinished business here still, or should we proceed to merge?

Link to CONTRIBUTING.md added, cheers.

Thanks! Added all but `--export-ssh-key`, as I didn't have any keys around it would work with.

Any news to share about this? It'd be a great feature, making the extension a complete replacement for e-mail based notifications. The different notification levels as in GitLab's Profile ->...

Thanks for looking into this! (Edit: deleted some questioning which I see was due to myself just having read just a fraction of the fix.)

`.yaml` seems to be the "best practice" indeed, if any. - https://yaml.com/faq/ - https://yaml.org/faq.html - https://www.yaml.info/learn/bestpractices.html#file - https://en.wikipedia.org/wiki/YAML#cite_ref-12 None of these feel _that_ "authoritative" though. The yaml.org and .com are...

@hugo-sid @jakubroztocil sorry about the ping. This PR and its predecessor has existed for about 3 years, without receiving much commentary at all. It does have some problems still, but...

Nice. Just a minor correction/clarification/note related to @jcook-uptycs' comment and repeating mine above (see link in it): pre-commit handles this indeed, but the stashing it does is not `git stash`;...

Ah, cool to see you beat me to this. To be able to drop isort in Home Assistant, by chance? ;) I hadn't thought of this much, but skimming quickly...