Ville Skyttä

Results 283 comments of Ville Skyttä

I should also note that a bunch of the hints are actually inaccurate on Python 2 with regards to bytes/str/unicode. I guess it would be possible to improve on that...

Draft: I'm not sure I'm happy with this. Let's discuss in #420.

Hmph, yeah, I can see how that would happen. I wonder if a simple `trap "$reset" RETURN` or a derivative would be a pattern we could use to avoid this....

> `RETURN` doesn't seem to be invoked when the completion is canceled by `SIGINT` Would `trap '$reset' INT RETURN` "fix" the general signal part of this problem? Managing original traps...

Honestly, the uses cases the make completion caters for are way beyond my trivial make uses, and we'd really use a competent maintainer for it here in the project. I...

Suppressing error output from underlying invoked commands is a "cheap" general practice we tend to follow, because letting it through may cause an interleaved error/completion mess, the errors may make...

Not sure what's up with codecov. The service view takes a long time to load, errors most of the time. And local run says: ```shellsession $ pytest --cov=homeassistant.components.huawei_lte tests/components/huawei_lte Test...

For completeness, yes I think it would be good. Or ```python if any(action is x for x in (VariableVisitConsumerAction.RETURN, VariableVisitConsumerAction.CONSUME)): return ``` ...which subjectively scales better stylewise if there are...

That proposal surely is much easier on the eye, and I'm not surprised at all that it's more performant. However it arguably is not _correct_, `==` vs `is` is the...