Scott Chamberlain

including https://fishbaseapi.readme.io/docs/getting-started metadata and routes

Fishbase license/copyright

8

- [ ] copy/paste their copyright and/or license info on the fishbaseapi docs - and in R pkg docs - [ ] Rainer says they expect commercial users to pay...

so like ```json { "version": "v4", "count": 1000, "returned": 10, "data": [ { ... } ], "error": null } ```

Duplicates in genera table

1

E.g., ``` r library("RMySQL") library("dplyr") conn % .$GEN_NAME ``` ``` r length(gens) #> [1] 26261 length(unique(gens)) #> [1] 26164 ``` ``` r (lanceola % filter(GEN_NAME == "Lanceola") %>% collect()) lanceola...

https://fishbase.ropensci.org/docs and https://fishbase.ropensci.org/listfields when requested headers report a cache hit - im not sure why this is happening - caching should expire after 3600

from #97

Ignore case completely in fields parameter

3

Is there any reason to care about case at all? e.g., why not let `SpecCode`, `Speccode`, and `speccode` all work? Will see if there's any tables with fields with the...

Logging

2

after chatting with @EvilScott - we may want to change our logging strategy - I'll have a chat with their devops person at some point to hash this out

fishbase API future

1

A quick FYI to all watching this repo: Some nice folks are working with us to do an overhaul of the API codebase, and provide better hosting for the API...

Which tables need api routes?

14

@cboettig curious what tables you think would be good to have routes on? or are you mostly interested in replicating what the package already does, and the routes are secondary?