Scott Chamberlain comments

Results 1295 comments of


                                            Scott Chamberlain

Change to new cran checks badge URL

👋🏽 Shutting down the old cran checks badges tomorrow

Change to new cran checks badge URL

👋🏽 Shutting down the old cran checks badges tomorrow

Timeline?

> That is not what rgdal2 lets you do Okay, the `rgdal2` name suggested to me that it was a re-boot of `rgdal`. Sounds like that's not the case

Allowing `httr::write_disk` to actually create files

Thanks for the issue! I'll take a look and get back to you soon

Allowing `httr::write_disk` to actually create files

I assume you saw `?mocking-disk-writing` given your examples? See also https://github.com/ropensci/webmockr/issues/57 and https://github.com/ropensci/vcr/issues/81 I think the issue is that for this to work with `webmockr` the file has to exist...

Allowing `httr::write_disk` to actually create files

- Correct on httr w/o mocking - I think that's right. You can always just use `overwrite=TRUE` in `write_disk` - Right, that's clear I don't think it's outside what `webmockr`...

Allowing `httr::write_disk` to actually create files

I think i could support binary too. Would adding that be the last thing you need for this to be useable?

Allowing `httr::write_disk` to actually create files

Okay, I can make a change for binary support

Allowing `httr::write_disk` to actually create files

> If a mock_file is passed in then the content is always read into the registry and then is always written to the file path used in mock_file even when...

Allowing `httr::write_disk` to actually create files

> Interesting that Ruby forces you to save to disk manually - there's a lot that can go wrong there with content-type and encodings! Yeah, but I think actually R...