Scott Chamberlain comments

Results 1295 comments of


                                            Scott Chamberlain

Should we include data from journal supplementary files?

(p.s. `fulltext` has https://github.com/ropensci/fulltext/#supplementary-materials via Will Pearse - but an argument can be made to pull that functionality out of the pkg into another [here or elsewhere])

Should we include data from journal supplementary files?

> journals themselves aren't the relevant unit I'd think DOI prefix owners (often == publisher) are the relevant units

Prototype of an aggs parser handle.

thanks! I'll have a look in the morning

Prototype of an aggs parser handle.

Probably is good, But let me get the https://github.com/ropensci/elasticdsl/issues/6 sorted out first, then it'll be easier to play with this

Prototype of an aggs parser handle.

yeah, see #12

Incorporate last pipe detector from jqr

testing

Incorporate last pipe detector from jqr

did some improvements here, still more to do

Review dplyr's filter boolean logic implementation.

can you give an example of what that looks like?

Filter examples are currently broken.

Thanks for the report. Sorry about that, I think i remember those not working. There was relatively recent changes (_I think_) in the query vs. filter tooling in the ES...

Error in example code:

Thanks for the report, will have a look