Eric Schweitz

Are you saying the message needs to be improved? I believe the warning is technically true. The `goto 2` is jumping into a `DO` construct.

Has LLLVM HEAD been changed to allow DW_TAG_string_type as a valid tag now? (That change wasn't allowed to go in when I tried a few years ago, thus I'm asking.)...

> What specifically does not work with roundtripping? Is it the parser? To echo River's response, yes, the problem is with the parser.

It's been 6 months since the last post on this topic. Any thoughts or recommendations?

Q: is there a related phabricator review to this PR? Thanks for working on this.

> > Q: is there a related phabricator review to this PR? Thanks for working on this. > > @schweitzpgi Is a phabricator review what you would prefer for OpenMP...

I get compilation failures with this patch. ```console check-omp-structure.cpp:1020:65: error: ?const struct Fortran::parser::Verbatim? has no member named ?t? const auto &dirName{std::get(dir.t)}; ^ ```

This is crashing lowering at tip, which is an issue. On the other hand, this does not appear to be valid Fortran. 5 out of 5 Fortran compilers tested emit...

There is a bug is in the loop result optimization. The way it is rewriting loops looks like it may no longer be supported by MLIR.

Which driver is this using? `flang-new`? The driver needs to add the external name conversion pass to the pipeline. Without that pass, the internal unique names will be emitted.