Richard Schneeman

Results 473 comments of Richard Schneeman

Squashed and rebased, waiting for tests to run. Going to resolve prior comments.

CI is all green. Thanks for the review and your work 🙏

I had the desire to do this today. My use case is: I can induce a failure in the wild, but not in the library with doc tests: https://github.com/schneems/magic_migrate/pull/8.

@baldhadhaval08 IIRC the issue was that the code was not yet "promoted" from the staging S3 bucket (See GHA runs). After that happened it was fixed. So the focus of...

I responded in that other thread, restating here: If we cannot iterate on this interface directly, we should deprecate it in favor of one with fewer footguns. I opened up...

I disagree that the spec upstream has anything to say about the affordance over what goes into the output. i.e. it doesn't say if you should use it like: ```Bash...

In researching this, the original design is described as a "higher level" API for environment variables https://github.com/heroku/libcnb.rs/pull/30. I'm going to do an audit on all the places prepend is called...

In my real-life use case, I need to pass an env var to a command arg so I need bash to do the variable substitution https://github.com/heroku/buildpacks-ruby/blob/fd0402b5fad4785edcce5ccd3822a8bdd84ccebe/buildpacks/ruby/src/main.rs#L118-L121. I'm able to work...

Thanks for chiming in. I heard the talk but was fuzzy on the details. I just read the RFC https://github.com/buildpacks/rfcs/pull/168/files. It sounds like a proprietary format was introduced to support...

> But backticks do raise when the command isn't found (so will raise if Git isn't found): TIL. I didn't know it would do that. I guard all shell-ing out...