Richard Schneeman

Results 473 comments of Richard Schneeman

There's a few comments on docs. I took a stab at it in a stacked PR https://github.com/heroku/libcnb.rs/pull/864. Feedback/review is welcome over there or it's free to be merged in here...

> If instead, the alert's background color was a lightened/darkened variation of the color argument passed to the flash mixin, both the alert and the border bars would be visible....

Also "Could not load database configuration. No such file" is doubled here :/

> Also one option would be to set a default port instead of erroring, eg: If we set that as a default it would look like this to the user:...

FWIW I need exactly this feature to solve https://github.com/heroku/buildpacks-ruby/issues/302#issuecomment-2415128173. I found another crate https://crates.io/crates/cp_r, however that crate is missing options I need (like the ability to overwrite an existing file)...

Merged in https://github.com/heroku/heroku-buildpack-ruby/pull/1499

Thanks for the PR! Sorry for the silence. I've merged in in at https://github.com/heroku/heroku-buildpack-ruby/pull/1583. I'll deploy it tomorrow or early next week

Correct, the TODO here would be updating our node install logic when the node buildpack isn't being used. We would need to update https://github.com/heroku/heroku-buildpack-ruby/blob/cf25ace0e09675e744603962e12451943ce979be/lib/language_pack/helpers/nodebin.rb#L10.

Here's updated URLs https://github.com/heroku/buildpacks-nodejs/blob/e1d4420462be7526ec66a85da49445ac7de2b1c9/buildpacks/nodejs-engine/inventory.toml#L365-L377

Can you please pull in the latest from main and resolve conflicts.