libcnb.rs icon indicating copy to clipboard operation
libcnb.rs copied to clipboard

Failing test for #899: Inserting prepend multiple times overwrites instead of prepending

Open schneems opened this issue 8 months ago • 2 comments

#899

schneems avatar Apr 22 '25 00:04 schneems

This is currently working as designed in libcnb.rs. So this isn't a bug, but a request to change the API/design.

See: https://github.com/heroku/libcnb.rs/issues/899#issuecomment-2820246034

edmorley avatar Apr 22 '25 06:04 edmorley

I responded in that other thread, restating here: If we cannot iterate on this interface directly, we should deprecate it in favor of one with fewer footguns.

I opened up this PR #935 and then another PR with another failing test #936 and didn't notice that I made another mistake: forgetting to add a delimiter. I just fixed it in: https://github.com/heroku/libcnb.rs/pull/936/commits/7a5ff485603e55e65619f72359cd2388bf1bb6a1. There is an RFC to change the upstream default https://github.com/buildpacks/rfcs/pull/326, however, I don't think we need to wait for it. I think we should prefer "correctness" of programmer intent and productivity over "correctness of spec" unless doing so would violate major expectations or cause clear "one way door" type pain.

schneems avatar Apr 28 '25 15:04 schneems