Andrew Schmadel

Results 116 comments of Andrew Schmadel

I'm seeing something similar, using apollo-server and dd-trace 0.30.5 We're only seeing spans for top-level fields, while everything else seems to finish nearly instantaneously (including fields with resolvers that are...

We're not doing anything fancy with Apollo (ie. no schema-stitching or federation), but we are using `wrapSchema` and `addSchemaLevelResolver` from `graphql-tools`. At the end of the day, I'm pretty sure...

@rochdev Aha, perfect. That was the piece I was missing!

@riccardogiorato – I'd recommend [patch-package](https://github.com/ds300/patch-package/) for testing changes like this.

It ended up being fairly difficult to build a test-case for this, because the fix only really changes the recorded start-time and duration of the spans, and the current implementation...

I think that makes sense. It was a little surprising at first, but ultimately, I think it comes down to a visualization issue, given that the tracer is correctly recording...

I use unique jobs to ensure that there is only a single instance of a particular job type. However, I potentially might want to know more information about the runtime/logs...

why did we lock dependencies? among other things, this locked us into a dangerously-broken version of Redlock (v2.1.1)

indeed, it probably would! FWIW, I've had good luck with Redlock 3.0.0.

What do you think the appropriate behavior should be? Should `Queue.process()` throw an error if we try to call it on a non-worker, or should it simply not do anything?