Andrew Schmadel

Results 116 comments of Andrew Schmadel

I've been stuck on 1.2.28 for so long that I keep forgetting that `strictDi` exists. `strictDi` mitigates most of the risks of explicit-only annotations (ie. that you've forgotten an `"ngInject"`...

As I've mentioned, I'm in favor of leaving implicit matching in place for the time being. However, you've convinced me that 1.0.0 (ie. the first release I'll make with breaking...

There's also another babel plugin that seems like it's being developed in parallel: https://github.com/marcioj/babel-plugin-angular-annotate

I think the steps forward are: 1. Bump `babel-plugin-angularjs-annotate` to 1.0.0 and turn implicit matching off by default 2. Write a migration guide, and update `README.md` to reflect that we're...

I've taken a stab at updating the documentation for `babel-plugin-angularjs-annotate` in preparation for the 1.0.0 release. https://github.com/schmod/babel-plugin-angularjs-annotate/tree/next Proofreading and improvements are welcome ;-)

In that scenario, you'd probably want to opt for the TypeScript compiler to output ES6, and then run the output through babel to transpile to ES5. (Or, alternatively, there's nothing...

I don't think a fork is necessary. `moment-timezone` can depend upon a separate tzdata package, and NPM can take care of the rest. The only question would be how to...

The big problem is that `index.js` includes the entire dataset as a hard-coded dependency. Like Node, any module-bundler is going to resolve the dependency and include the entire thing. There...

A possible compromise: The default export of `moment-timezone` becomes a factory that returns a `moment` object decorated with `.tz`, and the exact set of locales that we've defined. The object...

@maggiepint -- That sounds good. I agree that this is the best place to start before we tackle the other issues at hand.