David Schlosnagle
David Schlosnagle
## What happened? Configuring additional error-prone checks to `ERROR` (or `WARNING`) requires some repetitive code in each project that wants to promote additional checks. See https://github.com/palantir/tritium/pull/254 and specifically https://github.com/palantir/tritium/pull/254/files#diff-c197962302397baf3a4cc36463dce5eaR75 ##...
## What happened? A [tritium develop build failed](https://app.circleci.com/pipelines/github/palantir/tritium/720/workflows/dd8ac7e6-159a-4ff5-9152-1cc2cfecf91c/jobs/10237) for https://github.com/palantir/tritium/pull/848 after merging the bump for `com.palantir.baseline:gradle-baseline-java` from `3.37.1` to `3.38.0`. The error message below and linked above poses a quite...
## What happened? Appears there was a flake in `checkImplicitDependenciesTest` for https://app.circleci.com/jobs/github/palantir/tritium/7611 with the error below. I triggered a rerun https://app.circleci.com/jobs/github/palantir/tritium/7653 that succeeded without any changes. Slightly tangential and probably...
## General **Before this PR**: `ImmutableCassandraServer` instances are created and used as Set elements & Map keys heavily, and would benefit from canonicalizing as there should be a relatively small,...
**Goals (and why)**: As noted in https://github.com/palantir/atlasdb/pull/6084#issuecomment-1157434783 `StackTraceUtils#score` is quite expensive `split`ting the full stacktrace on newlines twice for each sort comparison. ==COMMIT_MSG== Improve ThreadDumps and StackTraceUtils Reduce large string...
Follow up from https://github.com/palantir/atlasdb/pull/5517 / https://github.com/palantir/atlasdb/pull/5535 to migrate the places that `@SuppressWarnings("ProxyNonConstantType")` to use [proxy processor](https://github.com/palantir/proxy-processor) to enable atlasdb usage from graal native image.
## What happened? Gradle-baseline uses the [`net.ltgt.gradle:gradle-errorprone-plugin`](https://github.com/tbroyer/gradle-errorprone-plugin) but as noted in https://github.com/palantir/gradle-baseline/pull/2382#discussion_r971100394 it may be beneficial to remove the dependency on this plugin and just hook up error-prone directly when...
## General **Before this PR**: The unit test coverage for `CassandraService` was suboptimal, not catching a potential break in https://github.com/palantir/atlasdb/pull/6074 and did not simulate various cases when Cassandra cluster resizes...
## General **Before this PR**: Nit comment on https://github.com/palantir/atlasdb/pull/6213#discussion_r960989464 > we should clean up TableReference to use the com.palantir.logsafe.Preconditions instead of Guava, then we could get rid of this getTableRef(String)...
Follow up from https://github.com/palantir/atlasdb/pull/6225 The `com.palantir.atlasdb.keyvalue.api.watch.LockWatchEventLogTest#eventLogDoesNotDeadlockUnderConcurrentLoad` test is flaking a lot and causing failures on [develop](https://app.circleci.com/pipelines/github/palantir/atlasdb?branch=develop), [releases (e.g. 0.703.0)](https://app.circleci.com/pipelines/github/palantir/atlasdb/10000/workflows/8479699d-22ad-48f1-8fec-5e37f3b1d854) and PRs: - https://app.circleci.com/pipelines/github/palantir/atlasdb/10002/workflows/9cab9d39-7bae-4f69-b247-3edb54f5d160/jobs/37331 - https://app.circleci.com/pipelines/github/palantir/atlasdb/10012/workflows/ea15869f-0780-410d-81aa-59fa2a03cd71/jobs/37359