David Schlosnagle

Results 15 comments of David Schlosnagle

https://ses.library.usyd.edu.au/bitstream/handle/2123/5353/michael-cahill-2009-thesis.pdf may be of interest

Hi @k3KAW8Pnf7mkmdSMPHz27 , thanks for your contribution. Overall this looks good, and definitely appreciate fixes & switch from http to https. I think the original CI automated doc linting in...

@j-baker enabling something like this on atlasdb would have flagged https://github.com/palantir/atlasdb/pull/5039

A [re-run of the `check` and beyond portion of the build succeed](https://app.circleci.com/pipelines/github/palantir/tritium/720/workflows/d49af4ab-de30-422b-b011-d88598807e48/jobs/10245)

https://app.circleci.com/jobs/github/palantir/tritium/7658 also flaked

https://app.circleci.com/pipelines/github/palantir/tritium/369/workflows/161f7f4f-f4b1-48f9-b5e2-c85c742ec9f1/jobs/8220 also flaked

Does this get caught by promoting https://errorprone.info/bugpattern/MutableConstantField to error? That would also flag the downstream modification via https://errorprone.info/bugpattern/ImmutableModification

As seen in https://output.circle-artifacts.com/output/job/4a04c674-be62-456d-89cc-d98ba6365f3c/artifacts/4/home/circleci/artifacts/junit/atlasdb-impl-shared/test/classes/com.palantir.atlasdb.keyvalue.api.watch.LockWatchEventLogTest.html the `eventLogDoesNotDeadlockUnderConcurrentLoad` test currently takes ~11 seconds on Circle so was just flaking due to the 10 second executor shutdown timeout prior to #6225 . Locally...

I am a bit more hesitant to apply to `versions.props` since it is not autogenerated and has more entropy, but might be worth exploring. We don't currently enforce canonicalization of...