Barret Schloerke

Results 175 comments of Barret Schloerke

Ok. So `{sortable}` needs to not set the id values directly. Ex: * Mainly: https://github.com/rstudio/sortable/blob/8e24b8f688991622757a87118d9ba34d03a849ff/R/bucket_list.R#L154 * But also: https://github.com/rstudio/sortable/blob/8e24b8f688991622757a87118d9ba34d03a849ff/R/bucket_list.R#L17 When these values are set, they are unaware of the `NS`...

If the cache is not being updated on a successful Action given a cache hit, I think we should use the `actions/cache/restore@v3`. This would get rid of the message and...

Request to pass the `path` value from the _restore_ step to be able to use it in the _save_ step: https://github.com/actions/cache/issues/1082

> The drawback of this is that sometimes the reason for failure is botched packages installation Do you mean that the restore step works, but then the package installation fails?...

> > If it can be dynamic, I'm happy with it being opt-in. > > You can have alternative cache steps depending on an input parameter. Will do! ---------------- -...

(Rebased and squashed to remove the long-winded commit history)

If during packing installation, support was added for removing packages that are installed but not contained within the lock file, then it would fit with this approach nicely. This way,...

Will request a review when the PR is stable. Thank you!

> > Will request a review when the PR is stable. Thank you! > > I wonder if it was better and easier to implement this is in pak itself....

Proof of pruning packages: https://github.com/ggobi/ggally/actions/runs/7905722423/job/21578966735?pr=493#step:3:7274 ``` Run # Prune packages Prune unnecessary packages Removing unnecessary packages: httpuv, later, promises, shiny, sourcetools, xtable Removing packages from ‘/home/runner/work/_temp/Library’ (as ‘lib’ is unspecified)...