Barret Schloerke

Results 176 comments of Barret Schloerke

> Performance still wasn't good enough when styling 20000 features at once. Turns out it's something to do with how shiny sends different data types between R and JS. I...

Please make a pull request to https://github.com/leaflet-extras/leaflet-providers/blob/bc7482c62f1bbe3737682777716ec946e052deb6/leaflet-providers.js#L946-L953 with updated information Once accepted under https://github.com/leaflet-extras/leaflet-providers, we can update https://github.com/rstudio/leaflet.providers to the latest version. ----------------- Current `rstudio/leaflet.providers` version: 1.9.0 Current `leaflet-extras/leaflet.providers` version:...

Hi @EDiLD Could you ... " 2. Ensure that you have signed the [individual](https://rstudioblog.files.wordpress.com/2017/05/rstudio_individual_contributor_agreement.pdf) or [corporate](https://rstudioblog.files.wordpress.com/2017/05/rstudio_corporate_contributor_agreement.pdf) contributor agreement as appropriate. You can send the signed copy to [email protected]. " Excerpt...

I believe this is strongly related to #595 (and mtennekes/tmap#310 is probably related). This is caused by named geometry. If we look at the structure of the geometry object, it...

@jcheng5 What's the main idea for geometry items from sf? They should have no names whatsoever, correct? Or should we be recursively removing them?

Reopening until it is decided where the fix should take place

I'm using ``` sf * 0.7-4 2019-04-25 [1] CRAN (R 3.6.0) osmdata * 0.1.0 2019-04-25 [1] CRAN (R 3.6.0) ```

@tim-salabim Correct! I remember that issue as well. This seems different. The `named list` (with name `40154170-607395081-607395084`) is being returned in `osmdata_sf()`. ``` r library(sf) #> Linking to GEOS 3.6.1,...

Talking with @jcheng5, we'll make a fix in leaflet. Thank you for the quick explorations and motivations, everyone!