Barret Schloerke

waiting to re run docs once it's on cran

@matthewgthomas I love the idea of more colors! Any particular reason for these particular colors? I'm wondering if we should add the 12 color spectrums from colorbrewer2.org. http://colorbrewer2.org/#type=sequential&scheme=YlOrRd&n=9

The circle marker issue looks to be fixed without testing. https://github.com/stefanocudini/leaflet-search/issues/196 is not fixed as Path has not removed. Once Path is removed, I'll make a PR.

Somehow the layer feature is being added to the value object. The layer object is *very* recursive.

@daattali Found it. leaflet-search is poisoning the concept of the latlng object of the marker by adding the layer attribute. I think it will be safer to have leaflet.R fix...

Thank you for the reprex. I am able to reproduce the bug using the example link.

@jcheng5 I believe this is a new record for resolved conversations haha Everything should be in working order. Relevant diff: https://github.com/rstudio/shiny/pull/3644/files/8ac34098798259c4335f615ba6a17c564d12c764..19a106c896439b8ace1b22a2e8eee16fd30dac69 I'm not going to merge as I do not...

Removing from 1.2 milestone. Can be fixed at a later date

Agreed that it's possible to have it work with S4. One of the objects would be an S4 object, so S4 dispatch would occur when using an `Ops` method. I...

Timeline: The ggplot2 v3.3.0 release got me moving again on GGally. But it has been this way for years, so waiting another 6-12 months is not the end of the...