Sean

Results 209 comments of Sean

@Doctor06 we would love to make this one of the changes released with the [3.0.0 release](https://github.com/activerecord-hackery/ransack/issues/1210)

This is breaking the `not_null` predicate. Removing from [3.0.0 release](https://github.com/activerecord-hackery/ransack/issues/1210). ``` 1) Ransack::Adapters::ActiveRecord::Base negative conditions on HABTM associations removes redundant joins from top query Failure/Error: expect(sql).to_not include('LEFT OUTER JOIN') expected...

I have tested this and it errors when adding ``` id matches 3 ``` But is OK when ``` id equals 3 ``` Thanks for reporting @nAzgalor , will look...

Thank you @dkniffin. Any chance of writing a test against this feature? Just submit a PR with the tests only and refer this issue. It will help someone code it....

@deivid-rodriguez could you please review this refactoring. It should go after https://github.com/activerecord-hackery/ransack/pull/1345 I had intended to completely remove the `Ransack::Adapter::ActiveRecord` namespace and replace it with `Ransack::Adapter::ActiveRecord` but I could not...

@deivid-rodriguez can we get this into the 4.0.0 release also?

> I can try to review it, can you fix conflicts? @deivid-rodriguez sorry I didn't realise it had conflicts, will fix asap.

It's ready for review now @deivid-rodriguez

@deivid-rodriguez I will look at these comments over the weekend. I wonder if we should hold the 4.0.0 release so that this can come in? It is not a breaking...

It would be good to have some Globalize expertise to help with the gem, perhaps write some tests with a dummy app.