Sean

Results 207 comments of Sean

Took a look at this, the tests are green with the code merged, but we need a bit more detail before proceeding with it: - What problem is it trying...

Hi @mfazekas, thanks for the bug report. Any chance of writing a failing test? It will help the issue get resolved faster. Cheers

@mfazekas that would be awesome

Thank you @MrJoy could this awesome write-up be converted into a PR with the failing tests?

Reverted https://github.com/activerecord-hackery/ransack/pull/1263

@MrJoy hey there, thanks for the ping. It was reverted as the CI failed on merge. If you can get the CI to pass, we can definitely merge it.

@MrJoy sure thing, it looks like [it can't find a column](https://github.com/activerecord-hackery/ransack/runs/4162471415?check_suite_focus=true), but if you want to just create the merged PR with a note linking back here, perhaps someone will...

> so that it's there if/when your crew have the time/inclination to look at it. Not much of a crew here, but I'll try to look at it eventually.

This looks great but do we have test coverage?

@ciihla thank you for this contribution, is it possible to add a test (that would fail first without your PR) ?