Refactor adapters

[scarroll32]

Closes https://github.com/activerecord-hackery/ransack/issues/1346

[scarroll32]

@deivid-rodriguez could you please review this refactoring. It should go after https://github.com/activerecord-hackery/ransack/pull/1345

I had intended to completely remove the Ransack::Adapter::ActiveRecord namespace and replace it with Ransack::Adapter::ActiveRecord but I could not get past a connection error. It can be a follow-up issue.

[scarroll32]

@deivid-rodriguez can we get this into the 4.0.0 release also?

[deivid-rodriguez]

I can try to review it, can you fix conflicts?

[scarroll32]

I can try to review it, can you fix conflicts?

@deivid-rodriguez sorry I didn't realise it had conflicts, will fix asap.

[scarroll32]

It's ready for review now @deivid-rodriguez

[scarroll32]

@deivid-rodriguez I will look at these comments over the weekend. I wonder if we should hold the 4.0.0 release so that this can come in?

It is not a breaking change, but it is a large refactoring. I can go either way (either 4.0.0 or 4.1.0) WDYT ? 🤔

[deivid-rodriguez]

I think we can hold it until you can have a look. Breaking require "polyamorous" could be considered a breaking change so I'd ship it with 4.0.0 too.

Thanks for this @scarroll32!

[scarroll32]

@deivid-rodriguez could you please take another look at this in light of https://github.com/activerecord-hackery/ransack/pull/1371 and https://github.com/activerecord-hackery/ransack/pull/1370 ?

[scarroll32]

@deivid-rodriguez are you OK to merge this?