ransack icon indicating copy to clipboard operation
ransack copied to clipboard

Revert a change made in 2014 that prevent Ransack from finding the co…

Open michaelrobinette opened this issue 6 years ago • 6 comments

…rrect DB

michaelrobinette avatar Aug 08 '19 18:08 michaelrobinette

Can you add a test for this change?

deivid-rodriguez avatar Oct 16 '19 19:10 deivid-rodriguez

@michaelrobinette thanks for this PR. Can you add some explanation as to why it is needed, and a test would be awesome.

scarroll32 avatar Jan 12 '20 10:01 scarroll32

@michaelrobinette if we had a passing test for this we could merge it.

scarroll32 avatar Feb 23 '21 16:02 scarroll32

Closing as stale

scarroll32 avatar Nov 10 '21 15:11 scarroll32

Reopening: I'll rebase this and add a test.

scarroll32 avatar Mar 10 '22 13:03 scarroll32

Took a look at this, the tests are green with the code merged, but we need a bit more detail before proceeding with it:

  • What problem is it trying to solve?
  • Addition of a failing test on the current codebase, which is then green with the new code merged

Removing this from the 3.0.0 Release and adding the Blocked label until these points can be addressed.

scarroll32 avatar Mar 28 '22 07:03 scarroll32