sbulen

I agree with d3vcho here.

It cannot do so before the alert is created - because it queries the alerts above, and only deletes it if it exists already...

Yes, it is conceivable that the cleanup is attempted before the alert is posted (mainly if you're having system issues & cron isn't functioning). But that is such a narrow...

I believe this one is ready now.

I really don't think this is a 2.1.0 requirement. Could we remove or change the milestone?

Correct, mysql only. MB4 will require some db changes & increasing minimum version of mysql. But mb4 is definitely the right direction.

This only happens on an "action=" found in your image URL. All other uses of = test out fine & are not affected. https://github.com/SimpleMachines/SMF/blob/6d8394d172041ca1bec3ba249f922462ace8bc78/Sources/Subs.php#L2715 Which... Shouldn't be there??? Do you...

Why not use a different parameter in your mod, especially since action= has a very specific meaning in SMF?

Yes, it could be made tighter, e.g., check for the domain name/path from the $boardurl and only apply the edit then.

A couple notes on this: 1 - #7510 will fix the circumstances where the emails weren't sent when they should be sent. 2 - A clarification - due to the...