Stefan Büringer

I'm not sure if we can make this work without a breaking change to our go API structs (which would mean we have to wait until v1beta2)

To the best of my knowledge bool or list is not possible with crds (https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#intorstring cc @JoelSpeed). So I think we have to express this in a different way in...

Hm. I think we have a few options: * Delete the entire log statement * Delete only the source k/v pair * Use %T as value for the source k/v...

I think we didn't break it, it's just that not every source is nicely printable that way :) E.g. kind source looks better: > {"ts":1723448825525.443,"caller":"controller/controller.go:173","msg":"Starting EventSource","controller":"remote/clustercache","controllerGroup":"cluster.x-k8s.io","controllerKind":"Cluster","v":0,"source":"kind source: *v1beta1.Cluster"} Hm, I...

@tamalsaha What source are you using?

Is this a builtin source from controller-runtime or one that has been implemented outside of it?

Hm that's strange. I would have expected all of them to use the kind source and thus have a String() func and produce a similar output to: https://github.com/kubernetes-sigs/controller-runtime/issues/2914#issuecomment-2283825385

I'm wondering what logger is used that tries to convert the source to a JSON. We're using component-base in Cluster API and neither the text format (klog) nor the JSON...

/remove-lifecycle stale /lifecycle frozen

I'm not sure why those fields don't have `omitempty`. The only reason I can come up with is that we wanted to have those fields always visible to signal to...