Stefan Büringer
Stefan Büringer
Let's definitely default to something which is consistent with other kube-state-metrics metrics.
@chrischdi Great work, thank you very much! Looking forward to using this feature :)
+1 Employer: VMware
@vincepri @enxebre Given how long we spent on the previous PR, would be good to get a first opinion from your side.
> > From a quick glance, the current changes make sense to me, although these changes touch on the hashing code that @fabriziopandini was looking at for in place propagation...
``` and this is complex given that variables can be used in go templates or in external patches. ``` With our current implementation of external patches it's impossible to decide...
> > A defaulted field is optional from a user perspective as they don't have to specify it, with open api a required field can be defaulted and no error...
> I believe this one can be solved with the CEL when that eventually lands right? (I know you've mentioned that this is a long time away but I wanted...
We should take a look at how/if ServerSideValidation changes the situation: https://github.com/kubernetes/kubernetes/pull/108889
Also commented on the linked k/k issue, but just to mention it here. I think this statement is not correct ` The default field in openapi is "informational"`. The APIserver...