cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

v1beta1#ClusterStatus: some fields are missing ",omitempty"

Open ahmetb opened this issue 2 years ago • 12 comments

Hello, it appears most fields in ClusterStatus type have omitempty json tag. https://pkg.go.dev/sigs.k8s.io/cluster-api/api/v1beta1#ClusterStatus except for ControlPlaneReady and InfrastructureReady.

This prevents us from zeroing the .Status field on ClusterObject (which also has ,omitempty) and have a clean json result. https://pkg.go.dev/sigs.k8s.io/cluster-api/api/v1beta1#Cluster

Is this intentional? /kind support /area api cc: @reetasingh

ahmetb avatar Aug 19 '22 20:08 ahmetb