Spencer Bryngelson comments

Results 234 comments of


                                            Spencer Bryngelson

New example cases: Lid-driven cavity (compressible), double Mach, and more

Riemann problem taken care of in #256

New example cases: Lid-driven cavity (compressible), double Mach, and more

- [x] 3D: Inviscid and viscous isotropic Taylor--Green vortex by #573

Sub-grid bubble model

Converting this to draft as much of the checklist is still to be completed. Also there is significant code duplication in the source code (not DRY).

Fix benchmark divide by zero with proper error message

@anandrdbz out of convenience, I suppose. Please see this issue for a possible fix https://github.com/MFlowCode/MFC/issues/393

Fix benchmark divide by zero with proper error message

@anandrdbz After watching the last PR fail a few times here https://github.com/MFlowCode/MFC/actions/runs/8638692906/job/23683596528?pr=285 I'm not _really_ sure why there's a divide-by-zero problem or what is happening. It seems like one of...

Fix benchmark divide by zero with proper error message

Fixed by #423

CPU and GPU producing different results in some cases

> @wilfonba, is there a example case that can be used to test this on your fork ? FYI if you look at @wilfonba's most recent slides you'll see that...

CPU and GPU producing different results in some cases

Changing this from bug to "invalid". I think the real reason is just floating point problems. This happens across the board (different CPUs and compilers have this as well). The...

CPU and GPU producing different results in some cases

No activity on this. Closing.

Update `Final time` in the print statement to match `performance_expectations.md` and add benchmark case to `examples/`

Update: Probably want to switch both the code and the `.md` file in the docs to be ns per grid-point per equation per rhs evaluation (I updated the docs to...