Spencer Bryngelson
Spencer Bryngelson
Bump to top as the PR #119 was closed
Branch of code for `model_eqns == 2 .and. bubbles`: https://github.com/MFlowCode/MFC/blob/38ef7b9ee0b067a7b3d2e90f818965414e2359b7/src/simulation/m_riemann_solvers.fpp#L1421-L1856 Branch of code for `model_eqns == 2`: https://github.com/MFlowCode/MFC/blob/38ef7b9ee0b067a7b3d2e90f818965414e2359b7/src/simulation/m_riemann_solvers.fpp#L1858-L2164 These can be consolidated by adding an `if (bubbles) then` statement to...
Looking at refactoring some of these nasty bits of code would be a good introduction to the "meat" of the code @AiredaleDev @okBrian. Admittedly I'm a bit biased and would...
relevant: https://github.com/trixi-framework/HOHQMesh
Looking at some of these existing tools and knowing how MFC 'works,' I think using an existing package will be challenging. They often have compiler limitations, introduce a more modern...
Going to try something here https://github.com/sbryngelson/MFC/tree/unit
Starting working on something along these lines. Was curious what other folks are using for unit tests for finite volume schemes. Did not find many examples (at least open source...
I sort of ran out of ideas for good unit tests for a CFD solver, especially since MFC wasn't built via TDD. Open to suggestions.
No suggestion for this. Closing for now due to inactivity.
Update - PACE Phoenix should have an updated NVHPC by end of 2023.