Sébastien Besson

Results 278 comments of Sébastien Besson

Thanks @Rdornier, the new option makes sense from a code review perspective and the unit tests are passing. I'll pass onto @jburel and @will-moore for inclusion in the nightly CI...

Merging to fix conflicts with #4164 and unblock the performance work.

@Rdornier you are right that the two implementations behave differently. Going further, I believe the contract of these APIs and their signature was never expected to be compared directly. The...

Closing as per #4242, the writing improvements should be included in the upcoming Bio-Formats 8 release

@ebremer there have been several public reports about conversion performance. Over the last months, we have started reviewing various bottlenecks in the writing API for some specific scenarios. Ultimately some...

Closing as per #4242, the writing improvements should be included in the upcoming Bio-Formats 8 release

Thanks @scuniff and agreed that the width and the height should be casted to double to handle all scenarios. In practice, all the FV1000 samples in the OME curated data...

@WalkerKnapp we have reincluded this PR into the nightly CI builds to assess its impact on the curated QA repository. Assuming builds are passing and in order for us to...

A good starting point for this might be the logic in https://github.com/ome/bioformats/blob/1f03e09e22b0958f1e947669836650e842fed6b2/components/test-suite/src/loci/tests/testng/FormatReaderTest.java#L2973-L3001. This feature was been introduced in https://github.com/ome/bioformats/pull/3159 to identify whether the included changes are backwards-incompatible with memo files...

Ideally the gateway implementation should use the configuration service to retrieve the value of [omero-client-browser-thumb-default-size](https://omero.readthedocs.io/en/stable/sysadmins/config.html#omero-client-browser-thumb-default-size) and use this as the default value if `max_size` is not passed to the API...